This repository has been archived by the owner on Dec 16, 2019. It is now read-only.
Make everything validate with flake8 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
reviewed
Sep 12, 2018
tox.ini
Outdated
| commands = flake8 . | ||
|
|
||
| [testenv:flake8-tests] | ||
| changedir = tests |
There was a problem hiding this comment.
We could have a single section for flake8 instead one for tests and one for the code, but exclude the directories we don't want e.g.
[flake8]
ignore = E226,E302
exclude =
docker,
extras
[testenv:flake8]
deps = flake8
commands = flake8 .
[travis]
unignore_outcomes = True
python =
3.6: unit_tests, flake8
There was a problem hiding this comment.
see tox-travis for configuring tox for travis
blankdots
approved these changes
Sep 13, 2018
viklund
pushed a commit
that referenced
this pull request
Nov 22, 2018
Make everything validate with flake8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes everything compatible with flake8. Almost all changes are whitespace related.